From 605b976fb82e0bda1144c2e7bed503491be059a1 Mon Sep 17 00:00:00 2001 From: yy-fighting Date: Fri, 10 Jul 2026 03:13:11 +0000 Subject: [PATCH] sglang tp_dp_matrix: fix empty DATASET_PATH causing docker invalid spec When DATASET_PATH is empty, -v ::ro is passed to docker run, which produces 'invalid spec: ::ro: empty section between colons'. Build the volume args dynamically and only add the dataset mount when the path is non-empty. --- experiments/dsv4_h200_sglang_tp_dp_matrix/run_bench.sh | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/experiments/dsv4_h200_sglang_tp_dp_matrix/run_bench.sh b/experiments/dsv4_h200_sglang_tp_dp_matrix/run_bench.sh index 2291b8d..3f3bb3f 100755 --- a/experiments/dsv4_h200_sglang_tp_dp_matrix/run_bench.sh +++ b/experiments/dsv4_h200_sglang_tp_dp_matrix/run_bench.sh @@ -120,11 +120,15 @@ restart_server() { run_bench_serving() { # Run sglang.bench_serving either natively or inside the SGLang Docker image. if [[ "${USE_DOCKER_CLIENT:-1}" == "1" ]]; then + local vol_args=() + vol_args+=("-v" "${MODEL_PATH}:${MODEL_PATH}:ro") + if [[ -n "${DATASET_PATH:-}" ]]; then + vol_args+=("-v" "${DATASET_PATH}:${DATASET_PATH}:ro") + fi + vol_args+=("-v" "${RESULT_BASE}:${RESULT_BASE}") docker run --rm \ --network host \ - -v "${MODEL_PATH}:${MODEL_PATH}:ro" \ - -v "${DATASET_PATH}:${DATASET_PATH}:ro" \ - -v "${RESULT_BASE}:${RESULT_BASE}" \ + "${vol_args[@]}" \ -e PYTHONUNBUFFERED=1 \ "${DOCKER_IMAGE}" \ python -m sglang.bench_serving "$@"