From 8324d944f24f91c1b66bd455cba9b39b13414517 Mon Sep 17 00:00:00 2001 From: Quantong Qiu Date: Thu, 9 Jul 2026 02:53:38 +0000 Subject: [PATCH] fix(p800): define RUN_ID/RESULT_ROOT/LOG_DIR in start_server.sh start_server.sh referenced LOG_DIR and RESULT_ROOT without defining them, causing an unbound-variable failure under set -u. Mirror the initialization from run_bench.sh so the script can run standalone. --- experiments/dsv4_p800_sglang/start_server.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/experiments/dsv4_p800_sglang/start_server.sh b/experiments/dsv4_p800_sglang/start_server.sh index 63467b6..435865a 100755 --- a/experiments/dsv4_p800_sglang/start_server.sh +++ b/experiments/dsv4_p800_sglang/start_server.sh @@ -9,7 +9,11 @@ source "${SCRIPT_DIR}/../../scripts/common/server_docker.sh" # shellcheck source=/dev/null source "${SCRIPT_DIR}/config.env" -log_init "${RESULT_ROOT:-/tmp/${EXPERIMENT_NAME}}/logs/start_server.log" +RUN_ID="${RUN_ID:-$(date '+%Y%m%d-%H%M%S')}" +RESULT_ROOT="${RESULT_ROOT:-${SCRIPT_DIR}/results/${RUN_ID}}" +LOG_DIR="${RESULT_ROOT}/logs" + +log_init "${LOG_DIR}/start_server.log" log "starting server for ${EXPERIMENT_NAME}" log "model: ${MODEL_PATH}" log "port: ${PORT}"